Bug 159390 – [JSC] __lookupGetter__ and __lookupSetter__ should not ignore exceptions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[JSC] __lookupGetter__ and __lookupSetter__ should not ignore exceptions

[Benjamin Poulain]

Created attachment 282668 [details]
Patch

[Mark Lam]

Comment on attachment 282668 [details]
Patch

r=me

[Mark Lam]

Comment on attachment 282668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282668&action=review

> LayoutTests/js/script-tests/property-getters-and-setters.js:127
> +debug("__lookupGetter__ can be interupted by a proxy throwing an exception");

typo: /interupted/interrupted/

> LayoutTests/js/script-tests/property-getters-and-setters.js:142
> +debug("__lookupSetter__ can be interupted by a proxy throwing an exception");

typo: /interupted/interrupted/

[Build Bot]

Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1621108

New failing tests:
js/property-getters-and-setters.html

[Build Bot]

Created attachment 282669 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1621111

New failing tests:
js/property-getters-and-setters.html

[Build Bot]

Created attachment 282670 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1621112

New failing tests:
js/property-getters-and-setters.html

[Build Bot]

Created attachment 282671 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1621113

New failing tests:
js/property-getters-and-setters.html

[Build Bot]

Created attachment 282672 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Benjamin Poulain]

Created attachment 282673 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 282673 [details]
Patch

Clearing flags on attachment: 282673

Committed r202796: <http://trac.webkit.org/changeset/202796>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.