Bug 159390 - [JSC] __lookupGetter__ and __lookupSetter__ should not ignore exceptions
Summary: [JSC] __lookupGetter__ and __lookupSetter__ should not ignore exceptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-03 15:30 PDT by Benjamin Poulain
Modified: 2016-07-03 20:25 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.99 KB, patch)
2016-07-03 15:31 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (785.11 KB, application/zip)
2016-07-03 16:19 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (768.38 KB, application/zip)
2016-07-03 16:21 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.41 MB, application/zip)
2016-07-03 16:27 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (632.29 KB, application/zip)
2016-07-03 16:27 PDT, Build Bot
no flags Details
Patch (7.84 KB, patch)
2016-07-03 19:02 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-07-03 15:30:11 PDT
[JSC] __lookupGetter__ and __lookupSetter__ should not ignore exceptions
Comment 1 Benjamin Poulain 2016-07-03 15:31:57 PDT
Created attachment 282668 [details]
Patch
Comment 2 Mark Lam 2016-07-03 15:45:24 PDT
Comment on attachment 282668 [details]
Patch

r=me
Comment 3 Mark Lam 2016-07-03 15:50:36 PDT
Comment on attachment 282668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282668&action=review

> LayoutTests/js/script-tests/property-getters-and-setters.js:127
> +debug("__lookupGetter__ can be interupted by a proxy throwing an exception");

typo: /interupted/interrupted/

> LayoutTests/js/script-tests/property-getters-and-setters.js:142
> +debug("__lookupSetter__ can be interupted by a proxy throwing an exception");

typo: /interupted/interrupted/
Comment 4 Build Bot 2016-07-03 16:19:21 PDT
Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1621108

New failing tests:
js/property-getters-and-setters.html
Comment 5 Build Bot 2016-07-03 16:19:25 PDT
Created attachment 282669 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-07-03 16:21:33 PDT
Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1621111

New failing tests:
js/property-getters-and-setters.html
Comment 7 Build Bot 2016-07-03 16:21:37 PDT
Created attachment 282670 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-07-03 16:27:17 PDT
Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1621112

New failing tests:
js/property-getters-and-setters.html
Comment 9 Build Bot 2016-07-03 16:27:20 PDT
Created attachment 282671 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-07-03 16:27:53 PDT
Comment on attachment 282668 [details]
Patch

Attachment 282668 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1621113

New failing tests:
js/property-getters-and-setters.html
Comment 11 Build Bot 2016-07-03 16:27:56 PDT
Created attachment 282672 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 12 Benjamin Poulain 2016-07-03 19:02:19 PDT
Created attachment 282673 [details]
Patch
Comment 13 WebKit Commit Bot 2016-07-03 20:25:37 PDT
Comment on attachment 282673 [details]
Patch

Clearing flags on attachment: 282673

Committed r202796: <http://trac.webkit.org/changeset/202796>
Comment 14 WebKit Commit Bot 2016-07-03 20:25:43 PDT
All reviewed patches have been landed.  Closing bug.