Bug 159065 - Remove unused HarfBuzzFaceCoreText.cpp
Summary: Remove unused HarfBuzzFaceCoreText.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Reported: 2016-06-23 12:06 PDT by David Kilzer (:ddkilzer)
Modified: 2016-06-23 15:15 PDT (History)
2 users (show)

See Also:

Patch v1 (7.01 KB, patch)
2016-06-23 12:22 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-06-23 12:06:46 PDT
Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp was only ever used by Google Chrome.
Comment 1 David Kilzer (:ddkilzer) 2016-06-23 12:22:47 PDT
Created attachment 281926 [details]
Patch v1
Comment 2 Myles C. Maxfield 2016-06-23 14:07:29 PDT
Comment on attachment 281926 [details]
Patch v1

Isn't there more we can delete in this area?
Comment 3 WebKit Commit Bot 2016-06-23 14:29:05 PDT
Comment on attachment 281926 [details]
Patch v1

Clearing flags on attachment: 281926

Committed r202398: <http://trac.webkit.org/changeset/202398>
Comment 4 WebKit Commit Bot 2016-06-23 14:29:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 David Kilzer (:ddkilzer) 2016-06-23 15:15:26 PDT
(In reply to comment #2)
> Comment on attachment 281926 [details]
> Patch v1
> Isn't there more we can delete in this area?

If you're referring to other the Harfbuzz source files, the answer is No since the Efl and GTK ports both compile with Harfbuzz support:

$ grep -i -l harfbuzz Source/WebCore/Platform*.cmake