RESOLVED FIXED158734
Activate CMake export compile commands option 
https://bugs.webkit.org/show_bug.cgi?id=158734
Summary Activate CMake export compile commands option
youenn fablet
Reported 2016-06-14 07:00:52 PDT
This CMake option is activated for GTK only currently. But it might also be handy for other ports that use CMake. This option allows using ymcd autocompletion and is not consuming a lot of time according bug 131591.
Attachments
Patch (1.35 KB, patch)
2016-06-14 07:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-06-14 07:05:45 PDT
Created attachment 281256 [details] Patch
Alex Christensen
Comment 2 2016-06-14 09:08:19 PDT
Comment on attachment 281256 [details] Patch OMG YES!!!
WebKit Commit Bot
Comment 3 2016-06-14 09:31:13 PDT
Comment on attachment 281256 [details] Patch Clearing flags on attachment: 281256 Committed r202046: <http://trac.webkit.org/changeset/202046>
WebKit Commit Bot
Comment 4 2016-06-14 09:31:17 PDT
All reviewed patches have been landed. Closing bug.
youenn fablet
Comment 5 2016-06-14 09:45:00 PDT
youcompleteme is working on my setup for both gtk and mac platforms using the same config in Tools/gtk. Maybe we should move that config in a non gtk-folder?
ChangSeok Oh
Comment 6 2016-06-14 13:54:56 PDT
(In reply to comment #5) > youcompleteme is working on my setup for both gtk and mac platforms using > the same config in Tools/gtk. > Maybe we should move that config in a non gtk-folder? Interesting. Youenn, does cmake build work for mac port now? When I tried it few weeks ago, it was broken.
youenn fablet
Comment 7 2016-06-15 01:45:49 PDT
(In reply to comment #6) > (In reply to comment #5) > > youcompleteme is working on my setup for both gtk and mac platforms using > > the same config in Tools/gtk. > > Maybe we should move that config in a non gtk-folder? > > Interesting. Youenn, does cmake build work for mac port now? When I tried it > few weeks ago, it was broken. I think it compiles JSC and WebCore but fails generating some executables like DRT/WTR (compilation, link?). For the purpose of ycmd conf generation, it works just fine.
Note You need to log in before you can comment on or make changes to this bug.