Bug 158711 - Drop HipChat hack introduced in r197548
Summary: Drop HipChat hack introduced in r197548
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-13 16:34 PDT by Chris Dumez
Modified: 2016-06-13 21:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2016-06-13 16:36 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-06-13 16:34:06 PDT
Drop HipChat hack introduced in r197548. This hack is no longer needed as the bug was fixed in HipChat since then:
https://support.atlassian.com/servicedesk/customer/portal/32/HCP-7532

I have confirmed locally that the latest version (4.0.12.665) is able to connect without the hack.
Comment 1 Chris Dumez 2016-06-13 16:36:44 PDT
Created attachment 281213 [details]
Patch
Comment 2 Geoffrey Garen 2016-06-13 16:38:26 PDT
Comment on attachment 281213 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2016-06-13 17:09:40 PDT
Comment on attachment 281213 [details]
Patch

Clearing flags on attachment: 281213

Committed r202017: <http://trac.webkit.org/changeset/202017>
Comment 4 WebKit Commit Bot 2016-06-13 17:09:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2016-06-13 21:24:44 PDT
Nice!