Bug 158657 - Web Inspector: Show Exception Stack in UncaughtExceptionReporter view
Summary: Web Inspector: Show Exception Stack in UncaughtExceptionReporter view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on: 55092
Blocks:
  Show dependency tree / graph
 
Reported: 2016-06-11 01:25 PDT by Joseph Pecoraro
Modified: 2016-06-13 21:31 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.62 KB, patch)
2016-06-11 01:27 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] UncaughtExceptionView with stack (161.14 KB, image/png)
2016-06-11 01:27 PDT, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (3.64 KB, patch)
2016-06-11 01:30 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Exception Stack (155.78 KB, image/png)
2016-06-11 01:31 PDT, Joseph Pecoraro 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-06-11 01:25:57 PDT 
Summary:
Show Exception Stack in UncaughtExceptionReporter view

Not just the location, but the full stack when possible.

Requires bug 55092 so window.onerror includes the Error + potential stack with it.
Comment 1 Radar WebKit Bug Importer 2016-06-11 01:26:23 PDT 
<rdar://problem/26754441>
Comment 2 Joseph Pecoraro 2016-06-11 01:27:12 PDT 
Created attachment 281086 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-06-11 01:27:35 PDT 
Created attachment 281087 [details]
[IMAGE] UncaughtExceptionView with stack
Comment 4 Joseph Pecoraro 2016-06-11 01:28:54 PDT 
Comment on attachment 281086 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281086&action=review

> Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:162
> +            let slashIndex = line.lastIndexOf("/");

Oops, I should clearly handle when there isn't a '/' in the path (e.g. the [native code] examples in the screenshot).
Comment 5 Joseph Pecoraro 2016-06-11 01:30:50 PDT 
Created attachment 281088 [details]
[PATCH] Proposed Fix
Comment 6 Joseph Pecoraro 2016-06-11 01:31:15 PDT 
Created attachment 281089 [details]
[IMAGE] Exception Stack
Comment 7 WebKit Commit Bot 2016-06-13 21:31:30 PDT 
Comment on attachment 281088 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 281088

Committed r202025: <http://trac.webkit.org/changeset/202025>
Comment 8 WebKit Commit Bot 2016-06-13 21:31:34 PDT 
All reviewed patches have been landed.  Closing bug.