Bug 158613 - REGRESSION(r201880): WebSockets based remote inspector is broken since r201880
Summary: REGRESSION(r201880): WebSockets based remote inspector is broken since r201880
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2016-06-09 22:59 PDT by Carlos Garcia Campos
Modified: 2016-06-22 23:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.69 KB, patch)
2016-06-22 07:53 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-06-09 22:59:18 PDT 
It times out running the first test case, so my guess is that remote inspector is not working, probably due to web sockets being broken after r201880. I haven't looked at it in detail, though.

TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer: TIMEOUT
Comment 1 Carlos Garcia Campos 2016-06-22 07:48:29 PDT 
Not really GTK+ specific.
Comment 2 Carlos Garcia Campos 2016-06-22 07:53:09 PDT 
Created attachment 281838 [details]
Patch
Comment 3 Michael Catanzaro 2016-06-22 09:25:10 PDT 
Comment on attachment 281838 [details]
Patch

Looks straightforward. It needs an owner to rubber stamp before you commit. Darin?
Comment 4 Carlos Garcia Campos 2016-06-22 23:07:38 PDT 
(In reply to comment #3)
> Comment on attachment 281838 [details]
> Patch
> 
> Looks straightforward. It needs an owner to rubber stamp before you commit.
> Darin?

This is not exactly cross-platform code, it's only used by GTK+ and EFL, that's why it has been broken for so long and nobody noticed it.
Comment 5 Carlos Garcia Campos 2016-06-22 23:11:09 PDT 
Committed r202367: <http://trac.webkit.org/changeset/202367>