Bug 158060 - [css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default
Summary: [css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2016-05-25 00:18 PDT by Manuel Rego Casasnovas
Modified: 2016-05-25 12:38 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2016-05-25 00:21 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-05-25 00:18:28 PDT
[css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default
Comment 1 Manuel Rego Casasnovas 2016-05-25 00:21:08 PDT
Created attachment 279746 [details]
Patch

As @mcatanzaro suggested on bug #157391, I'm enabling CSS Grid Layout build flag by default.
Comment 2 Darin Adler 2016-05-25 03:32:15 PDT
Comment on attachment 279746 [details]
Patch

This only affects platforms using CMake. Is this already correct on Mac and iOS?
Comment 3 Csaba Osztrogonác 2016-05-25 05:36:58 PDT
(In reply to comment #2)
> Comment on attachment 279746 [details]
> Patch
> 
> This only affects platforms using CMake. Is this already correct on Mac and
> iOS?

It is already enabled in FeatureDefines.xcconfig files.

What about the EFL port? Don't you guys want to enable this feature?
It seems EFL port is the last one disabling CSS Grid Layout.
Comment 4 Csaba Osztrogonác 2016-05-25 05:38:22 PDT
Ah, I was wrong, it is already enabled on EFL too because of FeatureList.pm.
But in this case there is no reason to disable it in cmake.
Comment 5 Darin Adler 2016-05-25 09:22:14 PDT
Comment on attachment 279746 [details]
Patch

OK.
Comment 6 WebKit Commit Bot 2016-05-25 12:38:37 PDT
Comment on attachment 279746 [details]
Patch

Clearing flags on attachment: 279746

Committed r201396: <http://trac.webkit.org/changeset/201396>
Comment 7 WebKit Commit Bot 2016-05-25 12:38:41 PDT
All reviewed patches have been landed.  Closing bug.