Bug 157963 – No popstate when WebKit navigates back to a stateless history entry with page cached

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Jiewen Tan]

For non-cached page, no popstate events will be fired when WebKit navigates back to it if it doesn't have a state (state object). However, if the page is restored from the cache, then WebKit will fire popstate events unconditionally.

[Jiewen Tan]

<rdar://problem/23414840>

[Jiewen Tan]

Created attachment 279516 [details]
Patch

[Build Bot]

Comment on attachment 279516 [details]
Patch

Attachment 279516 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1356163

New failing tests:
fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache.html

[Build Bot]

Created attachment 279522 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279516 [details]
Patch

Attachment 279516 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1356155

New failing tests:
fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache.html

[Build Bot]

Created attachment 279523 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279516 [details]
Patch

Attachment 279516 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1356097

New failing tests:
fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache.html

[Build Bot]

Created attachment 279524 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279516 [details]
Patch

Attachment 279516 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1356151

New failing tests:
fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache.html

[Build Bot]

Created attachment 279525 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Jiewen Tan]

Created attachment 279526 [details]
Patch

[Brent Fulgham]

Comment on attachment 279526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279526&action=review

This looks good, but I noticed a few typographical errors. Please fix them before you land.

> Source/WebCore/ChangeLog:3
> +        No popstate when WebKit navigates back to a stateless history entry with page cached

Null popstate event fired when navigating back to a cached page with a stateless history entry

> Source/WebCore/ChangeLog:9
> +        unconditionally if the page is cached. Therefore, align the behavior of cached cases to

... page is cached. This results in inconsistent behavior between initial navigations and cached navigations.

Align the behavior of initial and cached navigations so that we produce consistent events.

> LayoutTests/fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry.html:39
> +        debug('bact at page 1');

'back at page 1'

[Jiewen Tan]

Created attachment 279569 [details]
Patch for landing

[Build Bot]

Comment on attachment 279569 [details]
Patch for landing

Attachment 279569 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1370603

New failing tests:
fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry.html

[Build Bot]

Created attachment 279573 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279569 [details]
Patch for landing

Attachment 279569 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1370604

New failing tests:
fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry.html

[Build Bot]

Created attachment 279574 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Jiewen Tan]

Created attachment 279576 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 279576 [details]
Patch for landing

Clearing flags on attachment: 279576

Committed r201310: <http://trac.webkit.org/changeset/201310>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas Forschler]

Mass move bugs into the DOM component.