Bug 157847 - [iOS] Fullscreen video playback broken in WK1 apps
Summary: [iOS] Fullscreen video playback broken in WK1 apps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-18 10:41 PDT by Eric Carlson
Modified: 2016-05-18 17:21 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (20.33 KB, patch)
2016-05-18 14:06 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing. (20.43 KB, patch)
2016-05-18 14:52 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-yosemite (12.27 MB, application/zip)
2016-05-18 16:31 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-05-18 10:41:56 PDT 
The WebVideoFullscreenInterface/WebVideoFullscreenModel/WebPlaybackSessionModel refactoring broke playback in WebKit 1 clients.
Comment 1 Eric Carlson 2016-05-18 10:42:44 PDT 
<Rdar://problem/25879521>
Comment 2 Eric Carlson 2016-05-18 14:06:12 PDT 
Created attachment 279280 [details]
Proposed patch
Comment 3 Jer Noble 2016-05-18 14:08:35 PDT 
Comment on attachment 279280 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279280&action=review

R=me, with nit:

> Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h:59
> +    WebPlaybackSessionModelMediaElement& playbackSessionModel() { return *m_playbackSessionModel.ptr(); }

This can just "return m_playbackSessionModel;". There's an auto-cast to the ref type from Ref<>.
Comment 4 Eric Carlson 2016-05-18 14:52:27 PDT 
Created attachment 279287 [details]
Patch for landing.
Comment 5 Build Bot 2016-05-18 16:31:08 PDT 
Comment on attachment 279287 [details]
Patch for landing.

Attachment 279287 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1344825

New failing tests:
storage/indexeddb/modern/handle-user-delete.html
Comment 6 Build Bot 2016-05-18 16:31:12 PDT 
Created attachment 279316 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Eric Carlson 2016-05-18 17:20:29 PDT 
Committed r201119: https://trac.webkit.org/r201119