Bug 157536 - Make the different evaluateWithScopeExtension implementations more consistent
Summary: Make the different evaluateWithScopeExtension implementations more consistent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-10 14:38 PDT by Joseph Pecoraro
Modified: 2016-05-10 16:11 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.16 KB, patch)
2016-05-10 14:40 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-10 14:38:13 PDT 
* SUMMARY
Make the different evaluateWithScopeExtension implementations more consistent.

Currently they slightly differ in handling exceptions and error messages. Make them consistent.
Comment 1 Joseph Pecoraro 2016-05-10 14:40:30 PDT 
Created attachment 278533 [details]
[PATCH] Proposed Fix

Nice and clean now for both impls.
Comment 2 WebKit Commit Bot 2016-05-10 16:11:04 PDT 
Comment on attachment 278533 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278533

Committed r200648: <http://trac.webkit.org/changeset/200648>
Comment 3 WebKit Commit Bot 2016-05-10 16:11:10 PDT 
All reviewed patches have been landed.  Closing bug.