Bug 15725 – [GTK] WebCore.pro header dependencies are incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alp Toker]

The list of header directories is incomplete, and there are still some 'gdk' paths from before the port was renamed.

This leads to failed builds and having to "make clean" quite often.

[Alp Toker]

Created attachment 16907 [details]
 Fix header dependencies in the build system


INCLUDEPATH and DEPENDPATH are now up to date.
---
 WebCore/WebCore.pro |   37 ++++++++++++++++++++++++++-----------
 1 files changed, 26 insertions(+), 11 deletions(-)

[Alp Toker]

(In reply to comment #1)
> Created an attachment (id=16907) [edit]
>  Fix header dependencies in the build system
> 
> 
> INCLUDEPATH and DEPENDPATH are now up to date.
> ---
>  WebCore/WebCore.pro |   37 ++++++++++++++++++++++++++-----------
>  1 files changed, 26 insertions(+), 11 deletions(-)
> 

Addendum:

diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro
index 271f296..7f5c0ff 100644
--- a/WebCore/WebCore.pro
+++ b/WebCore/WebCore.pro
@@ -131,6 +131,7 @@ INCLUDEPATH +=  $$PWD \
                 $$PWD/.. \
                 $$PWD/../JavaScriptCore/kjs \
                 $$PWD/../JavaScriptCore/bindings \
+                $$PWD/../JavaScriptCore/wtf \
                 $$PWD/platform \
                 $$PWD/platform/network \
                 $$PWD/platform/graphics \

[Adam Roben (:aroben)]

Comment on attachment 16907 [details]
 Fix header dependencies in the build system

r=me

[Mark Rowe (bdash)]

Alp, does this completely fix the problem or does it just improve the situation?

[Alp Toker]

Much improved, but I ended up with a crashy build and had to do a "make clean" earlier today, possibly following recent JSCore changes.

[Alp Toker]

Landed in r27234. Closing this bug, though not convinced all possible dependency issues are solved.