Bug 156937 - bmalloc: vm allocations should plant guard pages
Summary: bmalloc: vm allocations should plant guard pages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-22 16:43 PDT by Geoffrey Garen
Modified: 2016-04-28 12:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.93 KB, patch)
2016-04-22 16:44 PDT, Geoffrey Garen 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-04-22 16:43:13 PDT 
bmalloc: vm allocations should plant guard pages
Comment 1 Geoffrey Garen 2016-04-22 16:44:58 PDT 
Created attachment 277114 [details]
Patch
Comment 2 Michael Saboff 2016-04-22 16:54:57 PDT 
Comment on attachment 277114 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2016-04-22 16:56:30 PDT 
Committed r199936: <http://trac.webkit.org/changeset/199936>
Comment 4 Gavin Barraclough 2016-04-23 10:06:15 PDT 
Rolled out in r199950, looks like this is a memory regression.
Comment 5 Geoffrey Garen 2016-04-25 11:21:17 PDT 
Rolled back in: <http://trac.webkit.org/changeset/200035>.
Comment 6 Chris Dumez 2016-04-28 12:22:04 PDT 
The roll out in r199950 was a ~1% PLT progression.