Bug 156902 - Really enable INDEXED_DATABASE on Apple Mac cmake build
Summary: Really enable INDEXED_DATABASE on Apple Mac cmake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-22 02:26 PDT by Csaba Osztrogonác
Modified: 2016-04-23 19:27 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2016-04-22 02:27 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-04-22 02:26:04 PDT
INDEXED_DATABASE is enabled in OptionsMac.cmake, 
but disabled in FeatureList.pm which is stronger.
I think it is a mistake and should be enabled everywhere.

http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitperl/FeatureList.pm#L278
http://trac.webkit.org/browser/trunk/Source/cmake/OptionsMac.cmake#L48
Comment 1 Csaba Osztrogonác 2016-04-22 02:27:54 PDT
Created attachment 277031 [details]
Patch

note: It is a speculative fix, I don't have a Mac, so I can't test it at all.
Comment 2 Michael Catanzaro 2016-04-23 18:49:57 PDT
(EWS failure looks unrelated.)
Comment 3 WebKit Commit Bot 2016-04-23 19:27:11 PDT
Comment on attachment 277031 [details]
Patch

Clearing flags on attachment: 277031

Committed r199959: <http://trac.webkit.org/changeset/199959>
Comment 4 WebKit Commit Bot 2016-04-23 19:27:16 PDT
All reviewed patches have been landed.  Closing bug.