Bug 156428 - [WebIDL] Add support for [ExportMacro=XXX] IDL extended attribute
Summary: [WebIDL] Add support for [ExportMacro=XXX] IDL extended attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-08 16:41 PDT by Chris Dumez
Modified: 2016-04-08 20:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (21.29 KB, patch)
2016-04-08 16:58 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-08 16:41:20 PDT
Add support for [ExportMacro=XXX] IDL extended attribute (e.g. [ExportMacro=WEBCORE_EXPORT]) so developers can indicate in the IDL which macro to use to export the generated JS bindings class.
We currently support this by hard-coding JS class names in the bindings generator which is ugly.
Comment 1 Chris Dumez 2016-04-08 16:58:14 PDT
Created attachment 276058 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-08 20:07:43 PDT
Comment on attachment 276058 [details]
Patch

Clearing flags on attachment: 276058

Committed r199264: <http://trac.webkit.org/changeset/199264>
Comment 3 WebKit Commit Bot 2016-04-08 20:07:48 PDT
All reviewed patches have been landed.  Closing bug.