Bug 156335 - Migrate legacy perf dashboard tests to mocha.js based tests
Summary: Migrate legacy perf dashboard tests to mocha.js based tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-07 02:04 PDT by Ryosuke Niwa
Modified: 2016-04-07 15:10 PDT (History)
5 users (show)

See Also:


Attachments
Cleanup (246.94 KB, patch)
2016-04-07 02:21 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed the patch paths (248.26 KB, patch)
2016-04-07 12:37 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Another attempt (332.12 KB, patch)
2016-04-07 12:47 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-04-07 02:04:41 PDT
We have a bunch of legacy tests inside tests/ directory.
Migrate these tests to use the new harness added in http://trac.webkit.org/changeset/198642.
Comment 1 Ryosuke Niwa 2016-04-07 02:21:55 PDT
Created attachment 275872 [details]
Cleanup
Comment 2 Chris Dumez 2016-04-07 12:31:41 PDT
Patch does not apply?
Comment 3 Ryosuke Niwa 2016-04-07 12:37:33 PDT
Created attachment 275916 [details]
Fixed the patch paths
Comment 4 Chris Dumez 2016-04-07 12:38:40 PDT
Still doesn't
Comment 5 Ryosuke Niwa 2016-04-07 12:47:41 PDT
Created attachment 275919 [details]
Another attempt
Comment 6 Chris Dumez 2016-04-07 14:11:16 PDT
Comment on attachment 275919 [details]
Another attempt

View in context: https://bugs.webkit.org/attachment.cgi?id=275919&action=review

rs=me

> Websites/perf.webkit.org/ChangeLog:17
> +        Also deceased the timeout in most tests from 10s to 1s so that tests fail early when they timeout.

deceased -> decreased :)
Comment 7 Ryosuke Niwa 2016-04-07 15:10:50 PDT
Committed r199191: <http://trac.webkit.org/changeset/199191>