Bug 156181 - [JSC][x86] Fix an assertion in MacroAssembler::branch8()
Summary: [JSC][x86] Fix an assertion in MacroAssembler::branch8()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 13:52 PDT by Benjamin Poulain
Modified: 2016-04-04 15:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2016-04-04 13:54 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-04-04 13:52:33 PDT 
[JSC][x86] Fix an assertion in MacroAssembler::branch8()
Comment 1 Benjamin Poulain 2016-04-04 13:54:32 PDT 
Created attachment 275567 [details]
Patch
Comment 2 Geoffrey Garen 2016-04-04 14:23:05 PDT 
Comment on attachment 275567 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2016-04-04 14:24:33 PDT 
Maybe an even better version would be: static_cast<int8_t>(right.m_value) == right.m_value.
Comment 4 Benjamin Poulain 2016-04-04 14:46:10 PDT 
(In reply to comment #3)
> Maybe an even better version would be: static_cast<int8_t>(right.m_value) ==
> right.m_value.

IMHO, that's shorter but the explicit version is clearer.
Comment 5 WebKit Commit Bot 2016-04-04 15:12:18 PDT 
Comment on attachment 275567 [details]
Patch

Clearing flags on attachment: 275567

Committed r199025: <http://trac.webkit.org/changeset/199025>
Comment 6 WebKit Commit Bot 2016-04-04 15:12:23 PDT 
All reviewed patches have been landed.  Closing bug.