RESOLVED FIXED 156170
[ThreadedCompositor] Move CompositingRunLoop class into a separate file 
https://bugs.webkit.org/show_bug.cgi?id=156170
Summary [ThreadedCompositor] Move CompositingRunLoop class into a separate file
Zan Dobersek
Reported 2016-04-04 10:26:20 PDT
[ThreadedCompositor] Move CompositingRunLoop class into a separate file
Attachments
Patch (11.95 KB, patch)
2016-04-04 10:32 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-04-04 10:32:31 PDT
Created attachment 275558 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-04 10:33:42 PDT
Attachment 275558 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:47: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:51: The parameter name "timing" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:35: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:43: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2016-04-04 23:15:47 PDT
Comment on attachment 275558 [details] Patch Clearing flags on attachment: 275558 Committed r199048: <http://trac.webkit.org/changeset/199048>
Zan Dobersek
Comment 4 2016-04-04 23:15:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.