Bug 156170 - [ThreadedCompositor] Move CompositingRunLoop class into a separate file
Summary: [ThreadedCompositor] Move CompositingRunLoop class into a separate file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-04 10:26 PDT by Zan Dobersek
Modified: 2016-04-04 23:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.95 KB, patch)
2016-04-04 10:32 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-04-04 10:26:20 PDT 
[ThreadedCompositor] Move CompositingRunLoop class into a separate file
Comment 1 Zan Dobersek 2016-04-04 10:32:31 PDT 
Created attachment 275558 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-04 10:33:42 PDT 
Attachment 275558 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:51:  The parameter name "timing" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:35:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:43:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2016-04-04 23:15:47 PDT 
Comment on attachment 275558 [details]
Patch

Clearing flags on attachment: 275558

Committed r199048: <http://trac.webkit.org/changeset/199048>
Comment 4 Zan Dobersek 2016-04-04 23:15:56 PDT 
All reviewed patches have been landed.  Closing bug.