Bug 155910 - Dromaeo patch used by run-benchmark should not include an invalid address.
Summary: Dromaeo patch used by run-benchmark should not include an invalid address.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-25 17:32 PDT by dewei_zhu
Modified: 2016-03-25 19:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.65 KB, patch)
2016-03-25 17:32 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Patch for landing (11.86 KB, patch)
2016-03-25 18:10 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2016-03-25 17:32:37 PDT 
Dromaeo patch used by run-benchmark should not include an invalid address.
Comment 1 dewei_zhu 2016-03-25 17:32:58 PDT 
Created attachment 274959 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-25 17:34:12 PDT 
Attachment 274959 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2016-03-25 17:55:09 PDT 
Comment on attachment 274959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274959&action=review

> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:-6688
> --   <p><a href="http://www.w3.org/"><img height=48 alt=W3C src="http://www.w3.org/Icons/w3c_home" width=72></a>
> -+   <p><a href="http://www.w3.org/"><img height=48 alt=W3C src="http://127.0.0.1/Icons/w3c_home" width=72></a>

I think we shouldn't load from w3c.org. Why don't we remove src attribute instead?
Comment 4 dewei_zhu 2016-03-25 18:10:26 PDT 
Created attachment 274963 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-03-25 19:09:35 PDT 
Comment on attachment 274963 [details]
Patch for landing

Clearing flags on attachment: 274963

Committed r198706: <http://trac.webkit.org/changeset/198706>
Comment 6 WebKit Commit Bot 2016-03-25 19:09:39 PDT 
All reviewed patches have been landed.  Closing bug.