Bug 155806 - Screen queries should query the exact screen, not a default
Summary: Screen queries should query the exact screen, not a default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-23 14:04 PDT by Dean Jackson
Modified: 2016-03-23 14:21 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2016-03-23 14:10 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-03-23 14:04:54 PDT 
Screen queries should query the exact screen, not a default
Comment 1 Radar WebKit Bug Importer 2016-03-23 14:05:49 PDT 
<rdar://problem/25322916>
Comment 2 Dean Jackson 2016-03-23 14:10:41 PDT 
Created attachment 274776 [details]
Patch
Comment 3 Tim Horton 2016-03-23 14:15:03 PDT 
Comment on attachment 274776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274776&action=review

> Source/WebCore/ChangeLog:13
> +        and comment in some other helpers why a generic check it

"it ok"

> Source/WebCore/platform/mac/PlatformScreenMac.mm:87
> +    return NSBitsPerPixelFromDepth([screen depth]);

Dots, not []
Comment 4 Dean Jackson 2016-03-23 14:21:20 PDT 
Committed r198595: <http://trac.webkit.org/changeset/198595>