Bug 155660 – Sideways-scrollable RTL document has wrong initial and reload offset in WKWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Sideways-scrollable RTL document has wrong initial and reload offset in WKWebView

[Simon Fraser (smfr)]

Created attachment 274452 [details]
Patch

[WebKit Commit Bot]

Attachment 274452 [details] did not pass style-queue:


ERROR: Source/WebKit2/ChangeLog:16:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:17:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:19:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:20:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:21:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:22:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:23:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:24:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit2/ChangeLog:25:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 9 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 274452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274452&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1269
> +    _commitDidRestoreExposedRect = NO;

I would expect "didCommitLayerTree" to be after the commit is complete :D maybe _didCommitLayerTree should be called _commitLayerTree or _willCommitLayerTree or something. Or not.

[Simon Fraser (smfr)]

rdar://problem/22212662

https://trac.webkit.org/r198455
https://trac.webkit.org/r198456