Bug 155393 - Revert rewrite const as var workaround
Summary: Revert rewrite const as var workaround
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-12 11:54 PST by Saam Barati
Modified: 2016-03-31 17:24 PDT (History)
4 users (show)

See Also:

Attachments
patch (9.38 KB, patch)
2016-03-31 15:31 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (9.33 KB, patch)
2016-03-31 16:21 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-03-12 11:54:17 PST 
This should no longer be needed.
Comment 1 Saam Barati 2016-03-31 15:31:57 PDT 
Created attachment 275341 [details]
patch
Comment 2 WebKit Commit Bot 2016-03-31 15:34:37 PDT 
Attachment 275341 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2016-03-31 15:36:29 PDT 
Comment on attachment 275341 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275341&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please fix the style issue.
Comment 4 Saam Barati 2016-03-31 16:21:58 PDT 
Created attachment 275351 [details]
patch for landing

thanks for the review
Comment 5 WebKit Commit Bot 2016-03-31 17:24:16 PDT 
Comment on attachment 275351 [details]
patch for landing

Clearing flags on attachment: 275351

Committed r198932: <http://trac.webkit.org/changeset/198932>
Comment 6 WebKit Commit Bot 2016-03-31 17:24:19 PDT 
All reviewed patches have been landed.  Closing bug.