WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155393
Revert rewrite const as var workaround
https://bugs.webkit.org/show_bug.cgi?id=155393
Summary
Revert rewrite const as var workaround
Saam Barati
Reported
2016-03-12 11:54:17 PST
This should no longer be needed.
Attachments
patch
(9.38 KB, patch)
2016-03-31 15:31 PDT
,
Saam Barati
mark.lam
: review+
Details
Formatted Diff
Diff
patch for landing
(9.33 KB, patch)
2016-03-31 16:21 PDT
,
Saam Barati
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2016-03-31 15:31:57 PDT
Created
attachment 275341
[details]
patch
WebKit Commit Bot
Comment 2
2016-03-31 15:34:37 PDT
Attachment 275341
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3
2016-03-31 15:36:29 PDT
Comment on
attachment 275341
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=275341&action=review
r=me
> Source/WebCore/ChangeLog:8 > + No new tests (OOPS!).
Please fix the style issue.
Saam Barati
Comment 4
2016-03-31 16:21:58 PDT
Created
attachment 275351
[details]
patch for landing thanks for the review
WebKit Commit Bot
Comment 5
2016-03-31 17:24:16 PDT
Comment on
attachment 275351
[details]
patch for landing Clearing flags on attachment: 275351 Committed
r198932
: <
http://trac.webkit.org/changeset/198932
>
WebKit Commit Bot
Comment 6
2016-03-31 17:24:19 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug