Bug 154741 - Modern IDB: New database versions are never committed to SQLite
Summary: Modern IDB: New database versions are never committed to SQLite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2016-02-26 11:43 PST by Brady Eidson
Modified: 2016-02-26 20:44 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (25.05 KB, patch)
2016-02-26 15:32 PST, Brady Eidson 		achristensen: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (25.10 KB, patch)
2016-02-26 19:49 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-02-26 11:43:48 PST 
Modern IDB: New database versions are never committed to SQLite

<rdar://problem/24860952>
Comment 1 Brady Eidson 2016-02-26 15:26:13 PST 
Also noticed https://bugs.webkit.org/show_bug.cgi?id=154756 while working on this.
Comment 2 Brady Eidson 2016-02-26 15:32:55 PST 
Created attachment 272376 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-02-26 17:20:47 PST 
Comment on attachment 272376 [details]
Patch v1

Rejecting attachment 272376 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 272376, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/888131
Comment 4 Brady Eidson 2016-02-26 19:49:31 PST 
Created attachment 272394 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-02-26 20:39:02 PST 
Comment on attachment 272394 [details]
Patch for landing

Clearing flags on attachment: 272394

Committed r197231: <http://trac.webkit.org/changeset/197231>