RESOLVED FIXED154679
Enable MallocScribble when detecting leaks 
https://bugs.webkit.org/show_bug.cgi?id=154679
Summary Enable MallocScribble when detecting leaks
Alexey Proskuryakov
Reported 2016-02-25 09:44:41 PST
run-webkit-tests --leaks should automatically enable MallocScribble to better detect leaks. I haven't noticed any difference in my testing, however that's what the man page recommends.
Attachments
proposed patch (3.06 KB, patch)
2016-02-25 09:46 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-02-25 09:46:10 PST
Created attachment 272210 [details] proposed patch
Geoffrey Garen
Comment 2 2016-02-25 10:19:09 PST
Comment on attachment 272210 [details] proposed patch r=me
WebKit Commit Bot
Comment 3 2016-02-25 11:10:00 PST
Comment on attachment 272210 [details] proposed patch Clearing flags on attachment: 272210 Committed r197121: <http://trac.webkit.org/changeset/197121>
WebKit Commit Bot
Comment 4 2016-02-25 11:10:04 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2016-02-25 12:20:10 PST
Looks like this may have improved leaks bot reliability - two test runs after this landed both had ~10% more unique leaks detected than earlier builds. Feb 25 11:31 197122 failure #3219 Failed 5356 total leaks found for a total of 2,421,568 bytes. 212 unique leaks found. 2 failures 8 new passes Feb 25 11:11 197121 failure #3218 Failed 6363 total leaks found for a total of 825,760 bytes. 212 unique leaks found. 8 new passes Feb 25 08:57 197120 failure #3217 Failed 6633 total leaks found for a total of 2,543,504 bytes. 183 unique leaks found. 8 new passes Feb 25 08:38 197118 failure #3216 Failed 5214 total leaks found for a total of 1,477,264 bytes. 186 unique leaks found. 1 failures 8 new passes Feb 25 07:30 197114 failure #3215 Failed 4704 total leaks found for a total of 2,276,736 bytes. 164 unique leaks found. 1 failures 8 new passes Feb 25 02:37 197090 failure #3214 Failed 6043 total leaks found for a total of 2,446,448 bytes. 120 unique leaks found. 8 new passes Feb 24 21:07 197061 failure #3213 Failed 3428 total leaks found for a total of 2,132,768 bytes. 191 unique leaks found. 8 new passes Feb 24 18:55 197060 failure #3212 Failed 5858 total leaks found for a total of 2,453,840 bytes. 188 unique leaks found. 2 failures 8 new passes Feb 24 18:06 197059 failure #3211 Failed 5555 total leaks found for a total of 2,416,576 bytes. 187 unique leaks found. 2 failures 8 new passes Feb 24 17:47 197058 failure #3210 Failed 5430 total leaks found for a total of 1,524,432 bytes. 170 unique leaks found. 1 failures 8 new passes Feb 24 16:31 197057 failure #3209 Failed 5482 total leaks found for a total of 2,405,168 bytes. 190 unique leaks found. 1 failures 8 new passes Feb 24 16:08 197056 failure #3208 Failed 4184 total leaks found for a total of 2,214,768 bytes. 123 unique leaks found. 1 failures 8 new passes Feb 24 15:47 197055 failure #3207 Failed 5014 total leaks found for a total of 2,323,856 bytes. 199 unique leaks found. 1 failures 8 new passes Feb 24 15:28 197054 failure #3206 Failed 4882 total leaks found for a total of 2,313,440 bytes. 185 unique leaks found. 1 failures 8 new passes Feb 24 14:42 197052 failure #3205 Failed 6407 total leaks found for a total of 2,515,024 bytes. 188 unique leaks found. 8 new passes Feb 24 14:22 197051 failure #3204 Failed 4318 total leaks found for a total of 2,457,056 bytes. 182 unique leaks found. 8 new passes Feb 24 14:02 197049 failure #3203 Failed 4834 total leaks found for a total of 596,496 bytes. 142 unique leaks found. 8 new passes Feb 24 13:42 197045 failure #3202 Failed 6008 total leaks found for a total of 747,136 bytes. 197 unique leaks found. 1 failures 8 new passes
Note You need to log in before you can comment on or make changes to this bug.