Bug 154505 - Web Inspector: clean up generator selection in generate-inspector-protocol-bindings.py
Summary: Web Inspector: clean up generator selection in generate-inspector-protocol-bi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-20 13:42 PST by BJ Burg
Modified: 2022-03-01 02:44 PST (History)
12 users (show)

See Also:

Attachments
Proposed Fix (106.25 KB, patch)
2016-02-20 13:48 PST, BJ Burg 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-02-20 13:42:18 PST 
- alphabetize generators
- make Framework.Test have its own branch
- make the JSC branch test against Framework.JavaScriptCore
Comment 1 Radar WebKit Bug Importer 2016-02-20 13:42:31 PST 
<rdar://problem/24758042>
Comment 2 BJ Burg 2016-02-20 13:48:35 PST 
Created attachment 271868 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-02-20 13:50:19 PST 
Attachment 271868 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:133:  [generate_from_specification] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:135:  [generate_from_specification] Undefined variable 'CppAlternateBackendDispatcherHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:149:  [generate_from_specification] Undefined variable 'ObjCInternalHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:151:  [generate_from_specification] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:152:  [generate_from_specification] Undefined variable 'JSBackendCommandsGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:153:  [generate_from_specification] Undefined variable 'CppAlternateBackendDispatcherHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:154:  [generate_from_specification] Undefined variable 'CppBackendDispatcherHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:155:  [generate_from_specification] Undefined variable 'CppBackendDispatcherImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:156:  [generate_from_specification] Undefined variable 'CppFrontendDispatcherHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:157:  [generate_from_specification] Undefined variable 'CppFrontendDispatcherImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:158:  [generate_from_specification] Undefined variable 'CppProtocolTypesHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:159:  [generate_from_specification] Undefined variable 'CppProtocolTypesImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:160:  [generate_from_specification] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:161:  [generate_from_specification] Undefined variable 'ObjCBackendDispatcherHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:162:  [generate_from_specification] Undefined variable 'ObjCBackendDispatcherImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:163:  [generate_from_specification] Undefined variable 'ObjCConfigurationHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:164:  [generate_from_specification] Undefined variable 'ObjCConfigurationImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:165:  [generate_from_specification] Undefined variable 'ObjCConversionHelpersGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:166:  [generate_from_specification] Undefined variable 'ObjCFrontendDispatcherImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:167:  [generate_from_specification] Undefined variable 'ObjCHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:169:  [generate_from_specification] Undefined variable 'ObjCProtocolTypesImplementationGenerator'  [pylint/E0602] [5]
Total errors found: 21 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 BJ Burg 2016-02-21 16:05:04 PST 
Committed r196880: <http://trac.webkit.org/changeset/196880>