[css-grid] Swap columns and rows in grid-template shorthand

[Manuel Rego Casasnovas]

[css-grid] Swap columns and rows in grid-template shorthand

[Manuel Rego Casasnovas]

Created attachment 271801 [details]
Patch

[Manuel Rego Casasnovas]

This is a patch ported from Blink:
https://crrev.com/3d6b5d3df0a988475328dc5a4aabce5c4f4aa211

[Darin Adler]

Comment on attachment 271801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271801&action=review

> Source/WebCore/css/CSSParser.cpp:5567
> +    if (RefPtr<CSSValue> columnsValue = parseGridTrackList()) {

I think auto is better here than naming the type.

> Source/WebCore/css/CSSParser.cpp:5659
> +    RefPtr<CSSValue> rowsValue = nullptr;

No need for the "= nullptr" here.

1) All new RefPtr objects are null.
2) All code paths below initialize rowsValue anyway.

> Source/WebCore/css/CSSParser.cpp:5666
> +        RefPtr<CSSValue> columnsValue = parseGridTemplateColumns();

I would  prefer auto here to naming the type.

[Manuel Rego Casasnovas]

Created attachment 271917 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 271917 [details]
Patch

Clearing flags on attachment: 271917

Committed r196934: <http://trac.webkit.org/changeset/196934>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.