Bug 154472 - [css-grid] Swap columns and rows in grid-template shorthand
Summary: [css-grid] Swap columns and rows in grid-template shorthand
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
Depends on:
Blocks: 60731 154915
  Show dependency treegraph
Reported: 2016-02-19 14:29 PST by Manuel Rego Casasnovas
Modified: 2016-03-02 03:40 PST (History)
4 users (show)

See Also:

Patch (34.31 KB, patch)
2016-02-19 14:29 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (34.41 KB, patch)
2016-02-22 05:22 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-02-19 14:29:06 PST
[css-grid] Swap columns and rows in grid-template shorthand
Comment 1 Manuel Rego Casasnovas 2016-02-19 14:29:42 PST
Created attachment 271801 [details]
Comment 2 Manuel Rego Casasnovas 2016-02-19 14:31:11 PST
This is a patch ported from Blink:
Comment 3 Darin Adler 2016-02-21 17:32:56 PST
Comment on attachment 271801 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=271801&action=review

> Source/WebCore/css/CSSParser.cpp:5567
> +    if (RefPtr<CSSValue> columnsValue = parseGridTrackList()) {

I think auto is better here than naming the type.

> Source/WebCore/css/CSSParser.cpp:5659
> +    RefPtr<CSSValue> rowsValue = nullptr;

No need for the "= nullptr" here.

1) All new RefPtr objects are null.
2) All code paths below initialize rowsValue anyway.

> Source/WebCore/css/CSSParser.cpp:5666
> +        RefPtr<CSSValue> columnsValue = parseGridTemplateColumns();

I would  prefer auto here to naming the type.
Comment 4 Manuel Rego Casasnovas 2016-02-22 05:22:12 PST
Created attachment 271917 [details]
Comment 5 WebKit Commit Bot 2016-02-22 06:08:38 PST
Comment on attachment 271917 [details]

Clearing flags on attachment: 271917

Committed r196934: <http://trac.webkit.org/changeset/196934>
Comment 6 WebKit Commit Bot 2016-02-22 06:08:42 PST
All reviewed patches have been landed.  Closing bug.