Bug 154396 - [Unforgeable] operations should not be writable as per Web IDL
Summary: [Unforgeable] operations should not be writable as per Web IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://heycam.github.io/webidl/#es-op...
Keywords: InRadar, WebExposed
Depends on: 154989 154999
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-18 08:59 PST by Chris Dumez
Modified: 2016-03-03 22:05 PST (History)
11 users (show)

See Also:

Attachments
Patch (20.28 KB, patch)
2016-02-18 09:33 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-02-18 08:59:11 PST 
[Unforgeable] operations should not be writable as per the Web IDL specification:
http://heycam.github.io/webidl/#es-operations

They were currently non-configurable in WebKit but still writable.
Comment 1 Radar WebKit Bug Importer 2016-02-18 08:59:42 PST 
<rdar://problem/24721063>
Comment 2 Chris Dumez 2016-02-18 09:33:53 PST 
Created attachment 271664 [details]
Patch
Comment 3 WebKit Commit Bot 2016-02-18 09:36:19 PST 
Attachment 271664 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:1023:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2016-02-18 12:18:36 PST 
Comment on attachment 271664 [details]
Patch

Clearing flags on attachment: 271664

Committed r196770: <http://trac.webkit.org/changeset/196770>
Comment 5 Chris Dumez 2016-02-18 12:18:42 PST 
All reviewed patches have been landed.  Closing bug.