WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
154211
Change the last RefPtr::get() to release() in String.prototype.normalize
https://bugs.webkit.org/show_bug.cgi?id=154211
Summary
Change the last RefPtr::get() to release() in String.prototype.normalize
Sukolsak Sakshuwong
Reported
2016-02-12 22:28:48 PST
Change the last RefPtr::get() to release() in String.prototype.normalize
Attachments
Patch
(1.45 KB, patch)
2016-02-12 22:30 PST
,
Sukolsak Sakshuwong
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1
2016-02-12 22:30:32 PST
Created
attachment 271272
[details]
Patch
WebKit Commit Bot
Comment 2
2016-02-12 23:22:00 PST
Comment on
attachment 271272
[details]
Patch Clearing flags on attachment: 271272 Committed
r196547
: <
http://trac.webkit.org/changeset/196547
>
WebKit Commit Bot
Comment 3
2016-02-12 23:22:03 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4
2016-02-21 17:01:33 PST
Comment on
attachment 271272
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=271272&action=review
> Source/JavaScriptCore/runtime/StringPrototype.cpp:1922 > + return jsString(exec, impl.release());
Should be WTFMove, not release, in new code.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug