Bug 15400 - [Gtk] JavaScriptCore gets compiled with icu-config compiler flags prepended, instead of appended
Summary: [Gtk] JavaScriptCore gets compiled with icu-config compiler flags prepended, ...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
: 15399 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-10-06 07:37 PDT by Ed Schouten
Modified: 2008-09-18 10:05 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Schouten 2007-10-06 07:37:04 PDT 
On my FreeBSD desktop, I can't compile WebKit, because the compiler flags of icu-config get prepended to the CXXFLAGS. The result:

c++ -c -pipe -D_REENTRANT -I/usr/local/include -O2 -fno-strict-aliasing -pipe -Wall -W -DBUILDING_GTK__ -I/usr/local/share/qt4/mkspecs/freebsd-g++ -I../../../../JavaScriptCore/kjs -I../../../../JavaScriptCore -I../../../../JavaScriptCore/kjs -I../../../../JavaScriptCore/bindings -I../../../../JavaScriptCore/bindings/c -I../../../../JavaScriptCore/wtf -Itmp -I../../../../JavaScriptCore -I../../../../JavaScriptCore/kjs -I../../../../JavaScriptCore/bindings -I../../../../JavaScriptCore/bindings/c -I../../../../JavaScriptCore/wtf -I../../../../JavaScriptCore/pcre -Itmp -I../../../../JavaScriptCore/kjs -I/usr/local/include -I. -o internal.o ../../../../JavaScriptCore/kjs/internal.cpp

This causes inclusions like pcre.h to fail, because my system's pcre.h gets included, instead of the shipped one.
Comment 1 Ed Schouten 2007-10-06 07:37:43 PDT 
*** Bug 15399 has been marked as a duplicate of this bug. ***
Comment 2 Mark Rowe (bdash) 2007-10-06 09:19:49 PDT 
I'm pretty sure this is caused by the following:

WebKit.pri:19:gtk-port:QMAKE_CXXFLAGS += $$system(icu-config --cppflags)

I'm not sure how to have qmake add the relevant flags at the end though.
Comment 3 Mike Hommey 2008-04-12 11:48:41 PDT 
Does this still apply with autogen.sh ?
Comment 4 Alp Toker 2008-09-18 10:05:13 PDT 
Please reopen bug if the issue persists.