Bug 153878 - Fix the !ENABLE(NETSCAPE_PLUGIN_API) build after r196053
Summary: Fix the !ENABLE(NETSCAPE_PLUGIN_API) build after r196053
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 151992
  Show dependency tree / graph
 
Reported: 2016-02-04 11:32 PST by Csaba Osztrogonác
Modified: 2016-02-04 22:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2016-02-04 11:34 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-02-04 11:32:59 PST 
build log:

In file included from ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:28:0:
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:39:59: error: expected class-name before '{' token
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:42:40: error: 'Display' has not been declared
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:49:13: error: 'NPWindowType' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:51:13: error: 'NPSetWindowCallbackStruct' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:54:33: error: 'WebCore::GraphicsContext' has not been declared
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:54:66: error: 'IntRect' in namespace 'WebCore' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:55:41: error: 'WebMouseEvent' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:56:41: error: 'WebWheelEvent' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:57:46: error: 'WebMouseEvent' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:58:46: error: 'WebMouseEvent' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:59:44: error: 'WebKeyboardEvent' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:63:5: error: 'Display' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:65:5: error: 'NPSetWindowCallbackStruct' does not name a type
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:50:19: error: 'virtual void* WebKit::NetscapePluginX11::window() const' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:52:18: error: 'virtual void WebKit::NetscapePluginX11::geometryDidChange()' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:53:18: error: 'virtual void WebKit::NetscapePluginX11::visibilityDidChange()' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:54:18: error: 'virtual void WebKit::NetscapePluginX11::paint(int&, const int&)' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:55:18: error: 'virtual bool WebKit::NetscapePluginX11::handleMouseEvent(const int&)' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:56:18: error: 'virtual bool WebKit::NetscapePluginX11::handleWheelEvent(const int&)' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:57:18: error: 'virtual bool WebKit::NetscapePluginX11::handleMouseEnterEvent(const int&)' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:58:18: error: 'virtual bool WebKit::NetscapePluginX11::handleMouseLeaveEvent(const int&)' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:59:18: error: 'virtual bool WebKit::NetscapePluginX11::handleKeyboardEvent(const int&)' marked override, but does not override
../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:60:18: error: 'virtual void WebKit::NetscapePluginX11::setFocus(bool)' marked override, but does not override
ICECC[12723] 20:26:07: Compiled on 10.6.1.14
Comment 1 Csaba Osztrogonác 2016-02-04 11:34:32 PST 
Created attachment 270675 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-04 12:06:29 PST 
Comment on attachment 270675 [details]
Patch

Clearing flags on attachment: 270675

Committed r196138: <http://trac.webkit.org/changeset/196138>
Comment 3 WebKit Commit Bot 2016-02-04 12:06:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Carlos Garcia Campos 2016-02-04 22:52:55 PST 
Sorry about this, thanks for fixing it Ossy.