Bug 153559 - Feature request: add "subdocument" resource type for content blockers
Summary: Feature request: add "subdocument" resource type for content blockers
Status: RESOLVED DUPLICATE of bug 219001
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-27 14:26 PST by Andrey Meshkov
Modified: 2021-05-19 14:20 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Meshkov 2016-01-27 14:26:19 PST 
Currently there is no way to distinguish frames from top windows.
Meanwhile this can be really useful for ad blocking.

Please read this github issue comments to find out why it may be useful:
https://github.com/AdguardTeam/AdguardBrowserExtension/issues/145
Comment 1 aitte 2016-06-02 12:02:13 PDT 
Dear Webkit developers, improving the Content Blocker API is very important! It is so close to being great but its limitations hold it back.

The #1 source of Content Blocker rules in Safari is via the Adblock Plus formatted lists, and people converting them into Content Blocker rules.

All of those lists contain "subdocument" blockers to remove ad-iframes, but to allow direct visits to those pages.

Since Safari doesn't distinguish between iframes and direct visits, those rules cannot be written in Safari's Content Blocker. Leading to bugs like this:

https://github.com/AdguardTeam/AdguardBrowserExtension/issues/262

Please, improve the Content Blocker API. It's very close to being superb, it just needs more features to uncripple it.
Comment 2 Radar WebKit Bug Importer 2019-04-11 22:54:12 PDT 
<rdar://problem/49841407>
Comment 3 Alex Christensen 2021-05-19 14:20:08 PDT 

*** This bug has been marked as a duplicate of bug 219001 ***