Bug 153546 - Air::TmpWidth uses a stale pointer into its HashMap after it calls add()
Summary: Air::TmpWidth uses a stale pointer into its HashMap after it calls add()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency tree / graph
 
Reported: 2016-01-27 09:07 PST by Filip Pizlo
Modified: 2016-01-27 12:11 PST (History)
10 users (show)

See Also:

Attachments
the patch (2.46 KB, patch)
2016-01-27 09:10 PST, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-27 09:07:30 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-27 09:10:39 PST 
Created attachment 270001 [details]
the patch
Comment 2 Saam Barati 2016-01-27 11:01:13 PST 
Comment on attachment 270001 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270001&action=review

r=me

> Source/JavaScriptCore/b3/air/AirTmpWidth.cpp:142
> +            // We already ensures that both tmps are added to the width map. That's important

I don't think this comment is needed given the above. 
If you think we need is, "ensures" => "ensure"
Comment 3 Filip Pizlo 2016-01-27 12:11:21 PST 
Landed in http://trac.webkit.org/changeset/195683