Bug 15350 - skip extra hash lookup and avoid converting char* to UString for 19% speedup on CK JS array test
Summary: skip extra hash lookup and avoid converting char* to UString for 19% speedup ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL: http://celtickane.com/projects/jsspee...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-02 16:08 PDT by Maciej Stachowiak
Modified: 2007-10-02 20:51 PDT (History)
0 users

See Also:

Attachments
patch implementing these two optimizations (1.48 KB, patch)
2007-10-02 16:30 PDT, Maciej Stachowiak 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-10-02 16:08:22 PDT 
The Celtic Kane JavaScript Benchmark "Array" test can be sped up 19% by using the return value from add() to avoid an extra hash lookup for contains(), and by storing some strings in function-scope static UString variables instead of as constant strings used to make new UStrings every time. These issues mainly affect the Array "join" and "toString" operations, which unfortunately seem to make up the vast majority of time on this benchmark.
Comment 1 Maciej Stachowiak 2007-10-02 16:30:12 PDT 
Created attachment 16509 [details]
patch implementing these two optimizations
Comment 2 Oliver Hunt 2007-10-02 16:37:17 PDT 
Comment on attachment 16509 [details]
patch implementing these two optimizations

ooh, nice and simple