WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15339
Use Vector<UChar> instead of DeprecatedString for innerHTML, for 35% speedup on CK DOM test
https://bugs.webkit.org/show_bug.cgi?id=15339
Summary
Use Vector<UChar> instead of DeprecatedString for innerHTML, for 35% speedup ...
Maciej Stachowiak
Reported
2007-10-02 00:26:08 PDT
createMarkup() is the guts of innerHTML - the way it is implemented now leads to lots of conversion between DeprecatedString and String, and lots of random concatenation. It could be much faster to use a Vector<UChar> and build the whole string in that, and then use String::adopt to do the whole operation without excess conversions.
Attachments
the speedup described plus a few more micro-optimizations to innerHTML
(34.87 KB, patch)
2007-10-02 00:58 PDT
,
Maciej Stachowiak
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1
2007-10-02 00:58:35 PDT
Created
attachment 16498
[details]
the speedup described plus a few more micro-optimizations to innerHTML
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug