Bug 153130 - [GTK] GVariant runtime critical errors when encoding session data
Summary: [GTK] GVariant runtime critical errors when encoding session data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-01-15 08:24 PST by Carlos Garcia Campos
Modified: 2016-01-16 01:37 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.23 KB, patch)
2016-01-15 08:30 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch (5.81 KB, patch)
2016-01-15 08:44 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-01-15 08:24:32 PST 
It happens when the FrameState has children, because the recursive serialization is wrong.

(epiphany:19881): GLib-CRITICAL **: g_variant_builder_open: assertion '!GVSB(builder)->expected_type || g_variant_type_is_subtype_of (type, GVSB(builder)->expected_type)' failed

(epiphany:19881): GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed

(epiphany:19881): GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed

(epiphany:19881): GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed

(epiphany:19881): GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed

(epiphany:19881): GLib-CRITICAL **: g_variant_builder_open: assertion '!GVSB(builder)->expected_type || g_variant_type_is_subtype_of (type, GVSB(builder)->expected_type)' failed
Comment 1 Carlos Garcia Campos 2016-01-15 08:30:57 PST 
Created attachment 269055 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-15 08:32:07 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2016-01-15 08:44:03 PST 
Created attachment 269060 [details]
Updated patch

The decode part also needed to be fixed.
Comment 4 Carlos Garcia Campos 2016-01-16 01:37:05 PST 
Committed r195166: <http://trac.webkit.org/changeset/195166>