Bug 153129 - Remove the SKIP_UNUSED_PARAM define
Summary: Remove the SKIP_UNUSED_PARAM define
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-15 07:52 PST by Csaba Osztrogonác
Modified: 2016-01-18 05:27 PST (History)
1 user (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2016-01-15 07:57 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-01-15 07:52:56 PST
http://trac.webkit.org/changeset/192464 (bug150166) introduced SKIP_UNUSED_PARAM 
define instead of "ENABLE(STREAMS_API) || ENABLE(MEDIA_STREAM)". It is used only
in Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.cpp file.

I think it is confusing, the parameters are used/unused in cpp, 
there is no reason to determine this fact in a different place.
Comment 1 Csaba Osztrogonác 2016-01-15 07:57:56 PST
Created attachment 269052 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-18 05:27:05 PST
Comment on attachment 269052 [details]
Patch

Clearing flags on attachment: 269052

Committed r195218: <http://trac.webkit.org/changeset/195218>
Comment 3 WebKit Commit Bot 2016-01-18 05:27:07 PST
All reviewed patches have been landed.  Closing bug.