WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153129
Remove the SKIP_UNUSED_PARAM define
https://bugs.webkit.org/show_bug.cgi?id=153129
Summary
Remove the SKIP_UNUSED_PARAM define
Csaba Osztrogonác
Reported
2016-01-15 07:52:56 PST
http://trac.webkit.org/changeset/192464
(
bug150166
) introduced SKIP_UNUSED_PARAM define instead of "ENABLE(STREAMS_API) || ENABLE(MEDIA_STREAM)". It is used only in Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.cpp file. I think it is confusing, the parameters are used/unused in cpp, there is no reason to determine this fact in a different place.
Attachments
Patch
(2.31 KB, patch)
2016-01-15 07:57 PST
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2016-01-15 07:57:56 PST
Created
attachment 269052
[details]
Patch
WebKit Commit Bot
Comment 2
2016-01-18 05:27:05 PST
Comment on
attachment 269052
[details]
Patch Clearing flags on attachment: 269052 Committed
r195218
: <
http://trac.webkit.org/changeset/195218
>
WebKit Commit Bot
Comment 3
2016-01-18 05:27:07 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug