Bug 152646 - Fix naming in HistoryItem to refer to scrollPositions
Summary: Fix naming in HistoryItem to refer to scrollPositions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-01 21:00 PST by Simon Fraser (smfr)
Modified: 2016-01-03 12:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.67 KB, patch)
2016-01-01 21:01 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-01-01 21:00:38 PST 
Fix naming in HistoryItem to refer to scrollPositions
Comment 1 Simon Fraser (smfr) 2016-01-01 21:01:48 PST 
Created attachment 268081 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-01 21:56:48 PST 
Comment on attachment 268081 [details]
Patch

Clearing flags on attachment: 268081

Committed r194492: <http://trac.webkit.org/changeset/194492>
Comment 3 WebKit Commit Bot 2016-01-01 21:56:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Simon Fraser (smfr) 2016-01-01 22:47:51 PST 
Commitbot, what u doin.
Comment 5 Simon Fraser (smfr) 2016-01-01 22:52:42 PST 
Alexey, why did commit queue commit this?
Comment 6 Tim Horton 2016-01-02 09:57:24 PST 
(In reply to comment #5)
> Alexey, why did commit queue commit this?

Why wouldn't it? Zalan cq+'d it, and Mac was fine.
Comment 7 Simon Fraser (smfr) 2016-01-03 09:54:59 PST 
commit-queue only looks at mac??
Comment 8 Tim Horton 2016-01-03 12:29:13 PST 
(In reply to comment #7)
> commit-queue only looks at mac??

Yes! There was a Contributors Meeting talk about making it wait on all platforms (and enforcing use of it), but also a fear that that might make it too slow.