Bug 152542 - RunBenchmark script should not require user interaction while running.
Summary: RunBenchmark script should not require user interaction while running.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-23 16:59 PST by dewei_zhu
Modified: 2015-12-24 00:15 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.57 KB, patch)
2015-12-23 16:59 PST, dewei_zhu
no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2015-12-23 17:08 PST, dewei_zhu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2015-12-23 16:59:12 PST
RunBenchmark script should not require user interaction while running.
Comment 1 dewei_zhu 2015-12-23 16:59:48 PST
Created attachment 267879 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-23 17:02:16 PST
Attachment 267879 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2015-12-23 17:02:55 PST
Comment on attachment 267879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267879&action=review

> Tools/ChangeLog:4
> +

You need to have a bug URL here.
Comment 4 dewei_zhu 2015-12-23 17:08:14 PST
Created attachment 267880 [details]
Patch
Comment 5 dewei_zhu 2015-12-23 17:11:17 PST
Committed r194406: <http://trac.webkit.org/changeset/194406>
Comment 6 Alex Christensen 2015-12-24 00:15:58 PST
Comment on attachment 267880 [details]
Patch

Removing r? to remove this from the review queue