Bug 152423 - [WinCairo] Empty context menu item.
Summary: [WinCairo] Empty context menu item.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-18 05:46 PST by peavo
Modified: 2015-12-19 00:38 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2015-12-18 05:51 PST, peavo 		no flags Details | Formatted Diff | Diff
Patch (1.32 KB, patch)
2015-12-18 11:38 PST, peavo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-12-18 05:46:09 PST 
The context menu contains a submenu item with no text.
Comment 1 peavo 2015-12-18 05:51:14 PST 
Created attachment 267625 [details]
Patch
Comment 2 Alex Christensen 2015-12-18 10:53:01 PST 
Comment on attachment 267625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267625&action=review

> Source/WebCore/page/ContextMenuController.cpp:801
> +#if PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN_CAIRO)
>      ContextMenuItem ShareMenuItem;

My guess is that all windows ports need this if WinCairo does.  How do I see this particular context menu?
Comment 3 peavo 2015-12-18 11:36:08 PST 
(In reply to comment #2)
> Comment on attachment 267625 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267625&action=review
> 
> > Source/WebCore/page/ContextMenuController.cpp:801
> > +#if PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN_CAIRO)
> >      ContextMenuItem ShareMenuItem;
> 
> My guess is that all windows ports need this if WinCairo does.  How do I see
> this particular context menu?

Good point :) I see the context menu with the empty item when I right-click any web page element in MiniBrowser.
Comment 4 peavo 2015-12-18 11:38:23 PST 
Created attachment 267645 [details]
Patch
Comment 5 WebKit Commit Bot 2015-12-18 16:25:58 PST 
Comment on attachment 267645 [details]
Patch

Clearing flags on attachment: 267645

Committed r194305: <http://trac.webkit.org/changeset/194305>
Comment 6 WebKit Commit Bot 2015-12-18 16:26:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 peavo 2015-12-19 00:38:26 PST 
Thanks for reviewing :)