Bug 152423 – [WinCairo] Empty context menu item.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

The context menu contains a submenu item with no text.

Created attachment 267625 [details]
Patch

[Alex Christensen]

Comment on attachment 267625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267625&action=review

> Source/WebCore/page/ContextMenuController.cpp:801
> +#if PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN_CAIRO)
>      ContextMenuItem ShareMenuItem;

My guess is that all windows ports need this if WinCairo does.  How do I see this particular context menu?

(In reply to comment #2)
> Comment on attachment 267625 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267625&action=review
> 
> > Source/WebCore/page/ContextMenuController.cpp:801
> > +#if PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN_CAIRO)
> >      ContextMenuItem ShareMenuItem;
> 
> My guess is that all windows ports need this if WinCairo does.  How do I see
> this particular context menu?

Good point :) I see the context menu with the empty item when I right-click any web page element in MiniBrowser.

Created attachment 267645 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 267645 [details]
Patch

Clearing flags on attachment: 267645

Committed r194305: <http://trac.webkit.org/changeset/194305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

Thanks for reviewing :)