Bug 152179 - Modern IDB: Updates to 3 intversion tests, and/or their results
Summary: Modern IDB: Updates to 3 intversion tests, and/or their results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 150882
  Show dependency tree / graph
 
Reported: 2015-12-11 10:50 PST by Brady Eidson
Modified: 2015-12-11 14:13 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (5.12 KB, patch)
2015-12-11 10:52 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 (5.94 KB, patch)
2015-12-11 11:01 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v3 (5.94 KB, patch)
2015-12-11 11:58 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-12-11 10:50:19 PST 
Modern IDB: Updates to 3 intversion tests, and/or their results
Comment 1 Brady Eidson 2015-12-11 10:52:06 PST 
Created attachment 267174 [details]
Patch v1
Comment 2 Brady Eidson 2015-12-11 11:01:39 PST 
Created attachment 267175 [details]
Patch v2
Comment 3 Brady Eidson 2015-12-11 11:02:12 PST 
This might not apply to trunk because it relies on patches from 152175 and 152177

It's still correct and reviewable.
Comment 4 Alex Christensen 2015-12-11 11:27:08 PST 
Comment on attachment 267175 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=267175&action=review

> LayoutTests/platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:24
> -PASS event.target.result is null
> +FAIL event.target.result should be undefined. Was null

What's this?
Comment 5 Brady Eidson 2015-12-11 11:58:02 PST 
Created attachment 267180 [details]
Patch v3
Comment 6 Brady Eidson 2015-12-11 13:30:21 PST 
(In reply to comment #4)
> Comment on attachment 267175 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267175&action=review
> 
> > LayoutTests/platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:24
> > -PASS event.target.result is null
> > +FAIL event.target.result should be undefined. Was null
> 
> What's this?

As we went over in person - WK2 (Legacy IDB) is known to get this wrong, so it is "correct" for WK2 to output a "FAIL" here.
Comment 7 WebKit Commit Bot 2015-12-11 14:13:06 PST 
Comment on attachment 267180 [details]
Patch v3

Clearing flags on attachment: 267180

Committed r193980: <http://trac.webkit.org/changeset/193980>
Comment 8 WebKit Commit Bot 2015-12-11 14:13:10 PST 
All reviewed patches have been landed.  Closing bug.