Bug 152151 - ResourceUsageOverlay should show GC timers.
Summary: ResourceUsageOverlay should show GC timers.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2015-12-10 14:41 PST by Andreas Kling
Modified: 2015-12-14 13:36 PST (History)
5 users (show)

See Also:

Patch (6.60 KB, patch)
2015-12-10 14:48 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-12-10 14:41:52 PST
Add countdowns until next GC (of both types) to the overlay.
Comment 1 Andreas Kling 2015-12-10 14:48:30 PST
Created attachment 267131 [details]
Comment 2 Darin Adler 2015-12-13 13:39:29 PST
Comment on attachment 267131 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=267131&action=review

> Source/JavaScriptCore/heap/GCActivityCallback.h:65
> +    double nextFireTime() const { return m_nextFireTime; }

We are trying to use std::chrono instead of plain doubles for this going forward.

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:440
> +    return String::format("%g", timerFireDate - now);

I think we have ways to do this without String:::format and we'd like to get rid of String::format. Maybe should rename it to deprecatedFormat. If nothing else this is easy with StringBuilder, I believe.
Comment 3 Andreas Kling 2015-12-14 12:48:43 PST
Comment on attachment 267131 [details]

Comments noted, will use std::chrono and StringBuilder when going over this soon again.
Comment 4 WebKit Commit Bot 2015-12-14 13:36:52 PST
Comment on attachment 267131 [details]

Clearing flags on attachment: 267131

Committed r194057: <http://trac.webkit.org/changeset/194057>
Comment 5 WebKit Commit Bot 2015-12-14 13:36:55 PST
All reviewed patches have been landed.  Closing bug.