ResourceUsageOverlay should show GC timers.

[Andreas Kling]

Add countdowns until next GC (of both types) to the overlay.

[Andreas Kling]

Created attachment 267131 [details]
Patch

[Darin Adler]

Comment on attachment 267131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267131&action=review

> Source/JavaScriptCore/heap/GCActivityCallback.h:65
> +    double nextFireTime() const { return m_nextFireTime; }

We are trying to use std::chrono instead of plain doubles for this going forward.

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:440
> +    return String::format("%g", timerFireDate - now);

I think we have ways to do this without String:::format and we'd like to get rid of String::format. Maybe should rename it to deprecatedFormat. If nothing else this is easy with StringBuilder, I believe.

[Andreas Kling]

Comment on attachment 267131 [details]
Patch

Comments noted, will use std::chrono and StringBuilder when going over this soon again.

[WebKit Commit Bot]

Comment on attachment 267131 [details]
Patch

Clearing flags on attachment: 267131

Committed r194057: <http://trac.webkit.org/changeset/194057>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.