WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
152034
Remove the unused #define _USE_MATH_DEFINES
https://bugs.webkit.org/show_bug.cgi?id=152034
Summary
Remove the unused #define _USE_MATH_DEFINES
Simon Fraser (smfr)
Reported
2015-12-08 20:29:58 PST
Remove the unused #define _USE_MATH_DEFINES
Attachments
Patch
(3.97 KB, patch)
2015-12-08 20:30 PST
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
Patch
(5.84 KB, patch)
2015-12-24 10:43 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2015-12-08 20:30:56 PST
Created
attachment 266963
[details]
Patch
Simon Fraser (smfr)
Comment 2
2015-12-08 21:09:06 PST
C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WTF\MediaTime.cpp(173): error C2065: 'M_PI': undeclared identifier [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWTFLib.vcxproj]
Brent Fulgham
Comment 3
2015-12-09 08:57:54 PST
(In reply to
comment #2
)
> C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WTF\MediaTime. > cpp(173): error C2065: 'M_PI': undeclared identifier > [C: > \cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWTFL > ib.vcxproj]
_USE_MATH_DEFINES is a Microsoft thing that defines M_PI and other things. I think we have all of this in wtf/MathExtras.h. Can you switch M_PI in this file to "piDouble"?
Brent Fulgham
Comment 4
2015-12-09 08:58:28 PST
(In reply to
comment #3
)
> (In reply to
comment #2
) > > C:\cygwin\home\buildbot\WebKit\Tools\TestWebKitAPI\Tests\WTF\MediaTime. > > cpp(173): error C2065: 'M_PI': undeclared identifier > > [C: > > \cygwin\home\buildbot\WebKit\WebKitBuild\Release\Tools\TestWebKitAPI\TestWTFL > > ib.vcxproj] > > _USE_MATH_DEFINES is a Microsoft thing that defines M_PI and other things. > > I think we have all of this in wtf/MathExtras.h. Can you switch M_PI in > this file to "piDouble"?
(You will probably need to add an include for 'wtf/MathExtras.h'
Simon Fraser (smfr)
Comment 5
2015-12-09 09:14:34 PST
Right, I think that's the right approach.
Simon Fraser (smfr)
Comment 6
2015-12-24 10:43:36 PST
Created
attachment 267901
[details]
Patch
WebKit Commit Bot
Comment 7
2015-12-24 12:48:15 PST
Comment on
attachment 267901
[details]
Patch Clearing flags on attachment: 267901 Committed
r194416
: <
http://trac.webkit.org/changeset/194416
>
WebKit Commit Bot
Comment 8
2015-12-24 12:48:19 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug