Bug 151733 - Teach DFG that ArithSub can now clobber the heap (and other things).
Summary: Teach DFG that ArithSub can now clobber the heap (and other things).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-01 17:21 PST by Mark Lam
Modified: 2015-12-02 12:11 PST (History)
6 users (show)

See Also:

Attachments
proposed patch. (4.35 KB, patch)
2015-12-01 17:38 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-12-01 17:21:46 PST 
Now that ArithSub can handle UntypedUse operands, we need to update the DFG's expectation of this node's properties.
Comment 1 Mark Lam 2015-12-01 17:38:12 PST 
Created attachment 266418 [details]
proposed patch.
Comment 2 Geoffrey Garen 2015-12-02 10:54:30 PST 
Comment on attachment 266418 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2015-12-02 11:16:47 PST 
Thanks for the review.  Landed in r192949: <http://trac.webkit.org/r192949>.
Comment 4 Filip Pizlo 2015-12-02 12:02:16 PST 
Comment on attachment 266418 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=266418&action=review

> Source/JavaScriptCore/dfg/DFGClobberize.h:262
> +#if USE(JSVALUE64)

Please remove this, it's not needed.
Comment 5 Mark Lam 2015-12-02 12:11:40 PST 
(In reply to comment #4)
> > Source/JavaScriptCore/dfg/DFGClobberize.h:262
> > +#if USE(JSVALUE64)
> 
> Please remove this, it's not needed.

Thanks.  Removed in r192952: <http://trac.webkit.org/r192952>.