RESOLVED FIXED151733
Teach DFG that ArithSub can now clobber the heap (and other things). 
https://bugs.webkit.org/show_bug.cgi?id=151733
Summary Teach DFG that ArithSub can now clobber the heap (and other things).
Mark Lam
Reported 2015-12-01 17:21:46 PST
Now that ArithSub can handle UntypedUse operands, we need to update the DFG's expectation of this node's properties.
Attachments
proposed patch. (4.35 KB, patch)
2015-12-01 17:38 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-12-01 17:38:12 PST
Created attachment 266418 [details] proposed patch.
Geoffrey Garen
Comment 2 2015-12-02 10:54:30 PST
Comment on attachment 266418 [details] proposed patch. r=me
Mark Lam
Comment 3 2015-12-02 11:16:47 PST
Thanks for the review. Landed in r192949: <http://trac.webkit.org/r192949>.
Filip Pizlo
Comment 4 2015-12-02 12:02:16 PST
Comment on attachment 266418 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=266418&action=review > Source/JavaScriptCore/dfg/DFGClobberize.h:262 > +#if USE(JSVALUE64) Please remove this, it's not needed.
Mark Lam
Comment 5 2015-12-02 12:11:40 PST
(In reply to comment #4) > > Source/JavaScriptCore/dfg/DFGClobberize.h:262 > > +#if USE(JSVALUE64) > > Please remove this, it's not needed. Thanks. Removed in r192952: <http://trac.webkit.org/r192952>.
Note You need to log in before you can comment on or make changes to this bug.