Bug 151719 - [iOS] Abrupt transition between Fullscreen -> PiP
Summary: [iOS] Abrupt transition between Fullscreen -> PiP
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-12-01 13:16 PST by Jer Noble
Modified: 2015-12-02 15:01 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2015-12-01 13:19 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2015-12-02 14:57 PST, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-12-01 13:16:24 PST 
[iOS] Abrupt transition between Fullscreen -> PiP
Comment 1 Jer Noble 2015-12-01 13:19:00 PST 
rdar://problem/23486521
Comment 2 Jer Noble 2015-12-01 13:19:34 PST 
Created attachment 266384 [details]
Patch
Comment 3 Eric Carlson 2015-12-01 13:23:12 PST 
Comment on attachment 266384 [details]
Patch

Nice simple fix! 
r=me
Comment 4 WebKit Commit Bot 2015-12-01 13:24:35 PST 
Attachment 266384 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1333:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2015-12-01 15:53:17 PST 
Comment on attachment 266384 [details]
Patch

Clearing flags on attachment: 266384

Committed r192922: <http://trac.webkit.org/changeset/192922>
Comment 6 WebKit Commit Bot 2015-12-01 15:53:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Jer Noble 2015-12-02 14:57:14 PST 
Reopening to attach new patch.
Comment 8 Jer Noble 2015-12-02 14:57:15 PST 
Created attachment 266474 [details]
Patch
Comment 9 Jer Noble 2015-12-02 15:01:43 PST 
Committed r192971: <http://trac.webkit.org/changeset/192971>