WebCore has a number of instances where things are not included explicitly or guarded properly. We should clean these up for consistency.
Created attachment 265908 [details] Patch Attached patch addresses include consistency issues that I know about.
Attachment 265908 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MicroTask.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/spi/mac/NSFontSPI.h:32: "wtf/Platform.h" already included at Source/WebCore/platform/spi/mac/NSFontSPI.h:26 [build/include] [4] ERROR: Source/WebCore/platform/graphics/IntSize.h:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:17: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:18: Line contains tab character. [whitespace/tab] [5] Total errors found: 9 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 265908 [details] did not pass style-queue: > > > ERROR: Source/WebCore/dom/MicroTask.h:27: Alphabetical sorting problem. > [build/include_order] [4] > ERROR: Source/WebCore/platform/spi/mac/NSFontSPI.h:32: "wtf/Platform.h" > already included at Source/WebCore/platform/spi/mac/NSFontSPI.h:26 > [build/include] [4] > ERROR: Source/WebCore/platform/graphics/IntSize.h:31: Alphabetical sorting > problem. [build/include_order] [4] > ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. > [whitespace/tab] [5] > ERROR: Source/WebCore/ChangeLog:10: Line contains tab character. > [whitespace/tab] [5] > ERROR: Source/WebCore/ChangeLog:13: Line contains tab character. > [whitespace/tab] [5] > ERROR: Source/WebCore/ChangeLog:14: Line contains tab character. > [whitespace/tab] [5] > ERROR: Source/WebCore/ChangeLog:17: Line contains tab character. > [whitespace/tab] [5] > ERROR: Source/WebCore/ChangeLog:18: Line contains tab character. > [whitespace/tab] [5] > Total errors found: 9 in 31 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I'll re-upload a patch which resolves these style issues.
Hmm, I do not think that headers are expected to include Platform.h at all.
(In reply to comment #4) > Hmm, I do not think that headers are expected to include Platform.h at all. Some of them do, I think, but some of the instances in my patch are invalid, yes.
(In reply to comment #5) > (In reply to comment #4) > > Hmm, I do not think that headers are expected to include Platform.h at all. > > Some of them do, I think If they do, we should probably fix those and remove them. Platform.h is supposed to be included indirectly by having the .cpp file include "config.h".