Bug 151366 - [JSC] Add an empty FTLOutput for B3 that crashes on any operation
Summary: [JSC] Add an empty FTLOutput for B3 that crashes on any operation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-17 15:29 PST by Benjamin Poulain
Modified: 2015-11-17 15:44 PST (History)
5 users (show)

See Also:

Attachments
Patch (22.98 KB, patch)
2015-11-17 15:29 PST, Benjamin Poulain 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-11-17 15:29:08 PST 
[JSC] Add an empty FTLOutput for B3 that crashes on any operation
Comment 1 Benjamin Poulain 2015-11-17 15:29:41 PST 
Created attachment 265712 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-17 15:31:46 PST 
Attachment 265712 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/B3Output.h:315:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:28:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLAbbreviatedTypes.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLAbbreviatedTypes.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2015-11-17 15:36:03 PST 
Comment on attachment 265712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265712&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        * ftl/B3Output.h: Added.

The only thing I don't love is the filename.

How about FTLB3Output.h?
Comment 4 Benjamin Poulain 2015-11-17 15:44:02 PST 
Committed r192546: <http://trac.webkit.org/changeset/192546>