Bug 151359 - [JSC] TailCalls should not trigger assertion failures when running with the jsc profiler on.
Summary: [JSC] TailCalls should not trigger assertion failures when running with the j...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks: 150812
  Show dependency tree / graph
 
Reported: 2015-11-17 14:27 PST by Keith Miller
Modified: 2015-11-18 16:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (14.18 KB, patch)
2015-11-17 15:01 PST, Keith Miller 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2015-11-17 14:27:40 PST 
[JSC] TailCalls should not trigger assertion failures when running with the jsc profiler on.
Comment 1 Keith Miller 2015-11-17 15:01:32 PST 
Created attachment 265710 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-17 15:04:11 PST 
Attachment 265710 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4046:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4048:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4068:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4070:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-11-17 16:10:40 PST 
Comment on attachment 265710 [details]
Patch

r=me
Comment 4 Keith Miller 2015-11-18 16:01:35 PST 
Committed r192596: <http://trac.webkit.org/changeset/192596>