When building webkit (or simply javascriptcore) on my aarch64 linux setup (with Tools/Scripts/build-{webkit,jsc} --gtk), I get undefined reference errors: [820/823] Linking CXX shared library lib/libjavascriptcoregtk-4.0.so.18.3.0 FAILED: : && /usr/bin/c++ -fPIC -std=c++11 -mfix-cortex-a53-835769 -std=c++11 -mfix-cortex-a53-835769 -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-strict-aliasing -fno-rtti -Wl,--no-undefined -Wl,--no-undefined -L/home/akiss/devel/WebKit/WebKitBuild/DependenciesGTK/Root/lib -shared -Wl,-soname,libjavascriptcoregtk-4.0.so.18 -o lib/libjavascriptcoregtk-4.0.so.18.3.0 @CMakeFiles/JavaScriptCore.rsp && : lib/../Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/Environment.cpp.o: In function `bmalloc::Environment::computeIsBmallocEnabled()': Environment.cpp:(.text+0xa8): undefined reference to `dlopen' Environment.cpp:(.text+0xbc): undefined reference to `dlsym' Environment.cpp:(.text+0xc8): undefined reference to `dlclose' collect2: error: ld returned 1 exit status It turns out that the symbols are referenced from the isASanEnabled() function and -ldl is indeed missing from the linker's command line.
Created attachment 265304 [details] Proposed patch
Comment on attachment 265304 [details] Proposed patch LGTM, r=me
Comment on attachment 265304 [details] Proposed patch Rejecting attachment 265304 [details] from commit-queue. akiss@inf.u-szeged.hu does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 265304 [details] Proposed patch Clearing flags on attachment: 265304 Committed r192336: <http://trac.webkit.org/changeset/192336>
All reviewed patches have been landed. Closing bug.