Bug 151005 - Use StringView::upconvertedCharacters() to make a 16-bit copy in String.prototype.normalize
Summary: Use StringView::upconvertedCharacters() to make a 16-bit copy in String.proto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-08 01:22 PST by Sukolsak Sakshuwong
Modified: 2015-11-08 10:36 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.49 KB, patch)
2015-11-08 01:31 PST, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-11-08 01:22:04 PST 
According to Darin Adler, the idiom for making a temporary 16-bit copy of a string is to use StringView::upconvertedCharacters(). (https://bugs.webkit.org/show_bug.cgi?id=147604#c9)
Comment 1 Sukolsak Sakshuwong 2015-11-08 01:31:25 PST 
Created attachment 265013 [details]
Patch
Comment 2 Michael Saboff 2015-11-08 07:21:52 PST 
Comment on attachment 265013 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-11-08 10:36:53 PST 
Comment on attachment 265013 [details]
Patch

Clearing flags on attachment: 265013

Committed r192146: <http://trac.webkit.org/changeset/192146>
Comment 4 WebKit Commit Bot 2015-11-08 10:36:56 PST 
All reviewed patches have been landed.  Closing bug.