Bug 150984 - AX: Input type: time is not accessible on iOS
Summary: AX: Input type: time is not accessible on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-06 16:20 PST by Nan Wang
Modified: 2015-11-09 13:16 PST (History)
11 users (show)

See Also:


Attachments
patch (2.53 KB, patch)
2015-11-06 16:53 PST, Nan Wang
no flags Details | Formatted Diff | Diff
patch (4.03 KB, patch)
2015-11-09 11:33 PST, Nan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2015-11-06 16:20:39 PST
<input type="time> is a popup button on iOS.
Comment 1 Nan Wang 2015-11-06 16:21:57 PST
<rdar://problem/22188153>
Comment 2 Nan Wang 2015-11-06 16:53:22 PST
Created attachment 264981 [details]
patch
Comment 3 chris fleizach 2015-11-06 17:04:31 PST
Comment on attachment 264981 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264981&action=review

missing changelings

> LayoutTests/accessibility/ios-simulator/input-type-time.html:23
> +        shouldBe("timeinput.description", "'AXLabel: (Between: 07:00 AM-09:00 AM)'");

you should also check if accessibilityIsIgnored (it should NOT be ignored)
Comment 4 Nan Wang 2015-11-09 11:33:30 PST
Created attachment 265077 [details]
patch
Comment 5 chris fleizach 2015-11-09 12:23:36 PST
Comment on attachment 265077 [details]
patch

seems like this test could run on all platforms right?
Comment 6 Nan Wang 2015-11-09 13:11:06 PST
(In reply to comment #5)
> Comment on attachment 265077 [details]
> patch
> 
> seems like this test could run on all platforms right?

It should be. But the change is only specific to iOS.
Comment 7 WebKit Commit Bot 2015-11-09 13:16:12 PST
Comment on attachment 265077 [details]
patch

Clearing flags on attachment: 265077

Committed r192173: <http://trac.webkit.org/changeset/192173>
Comment 8 WebKit Commit Bot 2015-11-09 13:16:18 PST
All reviewed patches have been landed.  Closing bug.