RESOLVED FIXED Bug 150860
Web Inspector: Remove duplication among ScriptDebugServer subclasses 
https://bugs.webkit.org/show_bug.cgi?id=150860
Summary Web Inspector: Remove duplication among ScriptDebugServer subclasses
Joseph Pecoraro
Reported 2015-11-03 15:08:23 PST
* SUMMARY Remove duplication among ScriptDebugServer subclasses. ScriptDebugServer subclasses each have their own addListener/removeListener implementation because they do different work when the first debugger attaches or the last detaches. However, the base class needs that list of listeners to dispatch its events. This is unnecessarily confusing. - Move addListener/removeListener and the list of listeners to the base class. - Make the only virtual work "attachDebugger" / "detachDebugger" when the first listener is added or last removed - Simplify related code that was duplicated as a result of the previous separation
Attachments
[PATCH] Proposed Fix (26.59 KB, patch)
2015-11-03 15:19 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-03 15:09:13 PST
<rdar://problem/23383158>
Joseph Pecoraro
Comment 2 2015-11-03 15:19:29 PST
Created attachment 264736 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2015-11-03 16:44:51 PST
Comment on attachment 264736 [details] [PATCH] Proposed Fix Clearing flags on attachment: 264736 Committed r191997: <http://trac.webkit.org/changeset/191997>
WebKit Commit Bot
Comment 4 2015-11-03 16:44:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.